Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPI support as plugins #966

Merged
merged 71 commits into from
Dec 5, 2023
Merged

MPI support as plugins #966

merged 71 commits into from
Dec 5, 2023

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Nov 22, 2023 •
edited
Loading

Description

Implementing MPI support as plugins as proposed in this RFC.

This helps improve compatibility in some deployment scenarios:

  • Docker images: libcudaq.so is no longer directly linked against OpenMPI in the docker image; hence allowing MPI lib swap when using the image.

  • Python wheels: with dynamical plugins, we don't need to disable MPI support during build. MPI support is deferred to runtime with support for mpi4py-based plugin or manually activated native MPI plugin.

Testing and CI

CI tests cover:

  • All 3 plugin deployment scenarios: built-in, mpi4py-based, and manually activated (test_in_devenv.yml)

  • OpenMPI and MPICH. To keep CI matrix size manageable, MPICH is only included in the matrix for the gcc toolchain.

  • Test MPI support in wheels (Run Python MPI tests in python_wheels.yml): activated for Ubuntu only.

@1tnguyen
Skeleton for MPI plugin
631369b
@1tnguyen
[WIP] Add python-based MPI Comm plugin
dbe8ffd
@1tnguyen
Fleshing out mpi4py plugin
774fb3e
@1tnguyen
Add unit test
41b5a07
@1tnguyen
Work on mpi4py plugin
2159f95
@1tnguyen
Add duplicate comm required for tensornet interop
93c96b9
@1tnguyen
Add comm dup/split test
17194f4
@1tnguyen
Merge branch 'main' into tnguyen/mpi
4621702
@1tnguyen
cutensornet backend to use plugin rather than link to MPI
e30cb7e
@1tnguyen
Fix test target name
d46273c
@1tnguyen
Missing headers for gcc-12
9f52335
@1tnguyen
Fix lifetime issues
545fa19
@1tnguyen
Fix wrong interpretation of MPI_Comm <-> void* conversion
15e3b9b
@1tnguyen
Expand the interface to cover CUTENSORNET_COMM_LIB
9b9d329
@1tnguyen
Add shim layer to use cudaq mpi plugin as cutn comm plugin if none pr…
5a442a1 
…ovided
@1tnguyen
further expand the api to cover all required MPI calls
c0ea5e1
@1tnguyen
Add allGatherV test
83b921f
@1tnguyen
Add Isend/Irecv tests
b48e6f9
@1tnguyen
Code format
104c012
@1tnguyen
Add doxygen comments
8d483ae
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
@cuda-quantum-bot
Docs preview for PR #966.
cbaa77a
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
@cuda-quantum-bot
Docs preview for PR #966.
24f6154
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
@cuda-quantum-bot
Docs preview for PR #966.
842f3eb
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
@cuda-quantum-bot
Docs preview for PR #966.
7309c06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
@cuda-quantum-bot
Docs preview for PR #966.
b010d9c
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@cuda-quantum-bot
Docs preview for PR #966.
0ba5553
bettinaheim
bettinaheim approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, aside from the one pending item regarding search path when a custom activation is needed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@cuda-quantum-bot
Docs preview for PR #966.
140e1ae
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@cuda-quantum-bot
Docs preview for PR #966.
02976ec
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@cuda-quantum-bot
Docs preview for PR #966.
9e2184c
@1tnguyen
Copy link
Collaborator Author

1tnguyen commented Dec 4, 2023 •
edited
Loading

Looks good to me, aside from the one pending item regarding search path when a custom activation is needed.

Adding the search path as discussed.

Also, I've posted ticket #1000 for documentation update for the next release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
@cuda-quantum-bot
Docs preview for PR #966.
cc7b985
@bettinaheim bettinaheim merged commit 035b084 into NVIDIA:main Dec 5, 2023
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@bettinaheim bettinaheim added the enhancement New feature or request label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 left review comments

@amccaskey amccaskey amccaskey left review comments

@bettinaheim bettinaheim bettinaheim approved these changes

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@1tnguyen @amccaskey @bettinaheim @bmhowe23