Add [[noreturn]] to set_error_and_throw_exception
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `[[noreturn]]` to `set_error_and_throw_exception`
Anerudhan
added a commit
that referenced
this pull request
Jan 31, 2024
[Bug fix] Fixed an issue where in some cases with padding the stats of SDPA forward node where having NANs. [Bug fix] In some older cuda toolkits, eg. cuda 11.4, float to half conversion is not implicit. This was raised in [PR-57](<#57>). Thanks @drisspg for reporting this. A more correct fix has been implemented in this patch. [Enhancement] Accepting github [PR-55](<#55>). Thanks @r-barnes for the suggestion.
Anerudhan
added a commit
that referenced
this pull request
Jan 31, 2024
[Bug fix] Fixed an issue where in some cases with padding the stats of SDPA forward node where having NANs. [Bug fix] In some older cuda toolkits, eg. cuda 11.4, float to half conversion is not implicit. This was raised in [PR-57](<#57>). Thanks @drisspg for reporting this. A more correct fix has been implemented in this patch. [Enhancement] Accepting github [PR-55](<#55>). Thanks @r-barnes for the suggestion.
Merged
Anerudhan
added a commit
that referenced
this pull request
Jan 31, 2024
[Bug fix] Fixed an issue where in some cases with padding the stats of SDPA forward node where having NANs. [Bug fix] In some older cuda toolkits, eg. cuda 11.4, float to half conversion is not implicit. This was raised in [PR-57](<#57>). Thanks @drisspg for reporting this. A more correct fix has been implemented in this patch. [Enhancement] Accepting github [PR-55](<#55>). Thanks @r-barnes for the suggestion.
|
Hi @r-barnes, Thank you for the message. cuDNN team has added the changes in 1.0.3 At this point we do not accept external PRs directly. Please re-open this if you need. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
[[noreturn]]toset_error_and_throw_exception