Fix: Failed to execute vagrant_startup.sh in Ubuntu 20.04 #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdecon
reviewed
Oct 26, 2021
virtual/vagrant_startup.sh
Outdated
| if [[ ! ${VERSION_ID} =~ ^20\.* ]]; then | ||
| APT_DEPENDENCIES=${APT_DEPENDENCIES}" libvirt-bin" | ||
| fi | ||
| export ${APT_DEPENDENCIES} |
There was a problem hiding this comment.
Correction: this line should be
export APT_DEPENDENCIES
ajdecon
requested changes
Oct 26, 2021
There was a problem hiding this comment.
Oops! It looked good, but I hadn't actually tested.
When I did:
+ APT_DEPENDENCIES='build-essential sshpass qemu-kvm libvirt-dev bridge-utils libguestfs-tools qemu ovmf virt-manager firewalld'
+ [[ ! 18.04 =~ ^20\.* ]]
+ APT_DEPENDENCIES='build-essential sshpass qemu-kvm libvirt-dev bridge-utils libguestfs-tools qemu ovmf virt-manager firewalld libvirt-bin'
+ export build-essential sshpass qemu-kvm libvirt-dev bridge-utils libguestfs-tools qemu ovmf virt-manager firewalld libvirt-bin
./vagrant_startup.sh: line 81: export: `build-essential': not a valid identifier
./vagrant_startup.sh: line 81: export: `qemu-kvm': not a valid identifier
./vagrant_startup.sh: line 81: export: `libvirt-dev': not a valid identifier
./vagrant_startup.sh: line 81: export: `bridge-utils': not a valid identifier
./vagrant_startup.sh: line 81: export: `libguestfs-tools': not a valid identifier
./vagrant_startup.sh: line 81: export: `virt-manager': not a valid identifier
./vagrant_startup.sh: line 81: export: `libvirt-bin': not a valid identifier
See comment inline for suggested fix.
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes below issues.