Fixing rsyslog-server role. #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The role didn't create the directory for storing the client's logs. In addition, I added an additional variable for the logs location: `rsyslog_log_file_path`.
1. The `molecule init` command has not a correct parameter. Instead of `--driver`, it should be `--driver-name`. 2. It is necessary to install `community.docker` Ansible Galaxy collection. It is not mentioned in any place. However, without this collection, it is not possible to work with molecule.
ajdecon
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
@mkunin-nvidia : Overall this PR looks fine to me, and I'll approve. Can't hurt to create this explicitly.
However, I'm curious where you've seen this fail? I know that we see this role succeed consistently in Jenkins tests, and the required directory is created. (I think rsyslog does this automatically.)
Sample output from a successful Jenkins test of the existing role here: https://gist.github.com/ajdecon/3fcbc1315c7c695c5aab429793f4be2e
|
@ajdecon I saw this in one of the recent customers. The folders inside are created but not the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role didn't create the directory for storing the client's logs.
In addition, I added an additional variable for the logs location:
rsyslog_log_file_path.