Misc fixes for Jenkins CI #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the deprecation of the "stable" Helm charts, the chart `stable/docker-registry` has been deprecated explicitly: helm/charts#24303 In particular, this chart no longer builds successfully, and the version that we had pinned to doesn't work with the latest Kubernetes: ``` stderr: 'Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "extensions/v1beta1"' ``` This commit swaps to using the chart pointed to at https://artifacthub.io/packages/helm/twuni/docker-registry, which appears to be the most actively maintained chart following the deprecation of the original. We may want to consider building our own at some point though...
dholt
reviewed
Mar 25, 2022
- Update to Kubespray v2.18.1 - Add containerd_insecure_registries configuration - Update test to use `ctr` command
- Increase timeouts - Update to most recent kube-prometheus-stack - Update monitoring test to account for use of GPU operator by default
| "registry.local:31500": "http://registry.local:31500" | ||
|
|
||
| # Work-around for https://github.com/kubernetes-sigs/kubespray/issues/8529 | ||
| nerdctl_extra_flags: " --insecure-registry" |
There was a problem hiding this comment.
Do we need to call out somewhere that we are defaulting to use this flag?
|
|
||
| echo "Test DCGM metrics" | ||
| sh ''' | ||
| timeout 500 bash -x ./workloads/jenkins/scripts/test-dcgm-metrics.sh slurm-node |
There was a problem hiding this comment.
Why are we removing this test?
| fi | ||
|
|
||
| # Commented out test-dcgm-metrics test, as with gpu-operator we no longer expose port 9400 directly on the nodes | ||
| #bash -x ./workloads/jenkins/scripts/test-dcgm-metrics.sh slurm-node # We use slurm-node here because it is GPU only, kube-node includes the mgmt plane |
There was a problem hiding this comment.
We should key off the "DEEPOPS_K8S_OPERATOR" variable for this. If set to "true we are using the operator. If left blank or set to false we are using device plugin.
We still claim to support both and the nightly testing goes down both paths.
supertetelman
approved these changes
Mar 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the merge of #1043 to update our Kubespray version and migrate to containerd, we're seeing some failures in Jenkins CI.
This PR is intended to let me work through these failures until we get a successful build. 😄
Changes include:
Test plan
All CI tests should pass