Honor fail-on-init-error when no resources are found #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As implemented GFD will not fail if no resources are detected -- even if fail-on-init-error is set. This change ensures that fail-on-init-error is honored if no resources are detected. Signed-off-by: Evan Lezar <elezar@nvidia.com>
ArangoGutierrez
previously approved these changes
Oct 31, 2024
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
fix-fail-on-init-error
branch
from
60cdc5a
to
b459765
Compare
elezar
added
the
maintenance
tariq1890
reviewed
Oct 31, 2024
tests/e2e/framework/framework.go
Outdated
| @@ -190,7 +190,7 @@ func (f *Framework) AfterEach(ctx context.Context) { | |||
| for namespaceKey, namespaceErr := range nsDeletionErrors { | |||
| messages = append(messages, fmt.Sprintf("Couldn't delete ns: %q: %s (%#v)", namespaceKey, namespaceErr, namespaceErr)) | |||
| } | |||
| e2elog.Failf(strings.Join(messages, ",")) | |||
| e2elog.Failf("%s", strings.Join(messages, ",")) | |||
There was a problem hiding this comment.
Or
Suggested change
| e2elog.Failf("%s", strings.Join(messages, ",")) | |
| e2elog.Fail(strings.Join(messages, ",")) |
tariq1890
previously approved these changes
Oct 31, 2024
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
fix-fail-on-init-error
branch
from
0ab326a
to
d986cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented GFD will not fail if no resources are detected -- even if fail-on-init-error is set. This change ensures that fail-on-init-error is honored if no resources are detected.
This backports #1033 to the release-0.15 branch