Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradient clipping to Static Capture Utilities #660

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Add gradient clipping to Static Capture Utilities #660

merged 5 commits into from
Aug 29, 2024

Conversation

dallasfoster
Copy link
Collaborator

Modulus Pull Request

Description

Adds gradient_clip_norm to the static capture utilities. This should be backward compatible with existing examples.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

@dallasfoster dallasfoster self-assigned this Aug 28, 2024
@dallasfoster
Copy link
Collaborator Author

/blossom-ci

@dallasfoster
Copy link
Collaborator Author

/blossom-ci

@dallasfoster dallasfoster mentioned this pull request Aug 28, 2024
Open
5 tasks
loliverhennigh
loliverhennigh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@loliverhennigh loliverhennigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Small commit on the unit test but not super needed.

Alexey-Kamenev
Alexey-Kamenev approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@Alexey-Kamenev Alexey-Kamenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

modulus/utils/capture.py Outdated Show resolved Hide resolved
modulus/utils/capture.py Outdated Show resolved Hide resolved
modulus/utils/capture.py Outdated Show resolved Hide resolved
@dallasfoster
Copy link
Collaborator Author

/blossom-ci

2 similar comments
@dallasfoster
Copy link
Collaborator Author

/blossom-ci

@dallasfoster
Copy link
Collaborator Author

/blossom-ci

@dallasfoster
Copy link
Collaborator Author

/blossom-ci

@dallasfoster dallasfoster merged commit 63cf3b4 into NVIDIA:main Aug 29, 2024
1 check passed
@dallasfoster dallasfoster mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexey-Kamenev Alexey-Kamenev Alexey-Kamenev approved these changes

@loliverhennigh loliverhennigh loliverhennigh approved these changes

@mnabian mnabian Awaiting requested review from mnabian

Assignees

@dallasfoster dallasfoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dallasfoster @loliverhennigh @Alexey-Kamenev