New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix]fix graph/xml.cc with checkBDFFormat typo bug #1268

Open

houqi wants to merge 1 commit into NVIDIA:master from houqi:patch-1

houqi commented Apr 28, 2024

fix type: checkBDFFormat
isHex(char == 0) => isHex(false) => false and makes

  if (isHex(bdf[0]) == 0 || isHex(bdf[1] == 0) || isHex(bdf[2] == 0) || isHex(bdf[3] == 0) ||
      isHex(bdf[5] == 0) || isHex(bdf[6] == 0) || isHex(bdf[8] == 0) || isHex(bdf[9] == 0) ||
      isHex(bdf[11] == 0)) return 0;

always true. should be

  if (isHex(bdf[0]) == 0 || isHex(bdf[1]) == 0 || isHex(bdf[2]) == 0 || isHex(bdf[3]) == 0 ||
      isHex(bdf[5]) == 0 || isHex(bdf[6]) == 0 || isHex(bdf[8]) == 0 || isHex(bdf[9]) == 0 ||
      isHex(bdf[11]) == 0) return 0;


          Update xml.cc with checkBDFFormat bug

b9d4e4c

Member

sjeaugey commented Apr 29, 2024

Thaks for the bug report. We'll fix that in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet