Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#48 rebased: "Allow JIT Compile to, and Link from, LTOIR for cuda source input" #60

Closed
wants to merge 4 commits into from

Conversation

gmarkall
Copy link
Collaborator

Following the merge of #23 / #56, this is #48 rebased on main for review.

The changes here should be the same as those in #48, except:

  • Merge base is main
  • No commits from the original Use pynvjitlink for MVC  #23 PR, the content of which is now in main.
  • Removed the style churn to simplify reading the diff.

cc @isVoid

@isVoid
Copy link
Collaborator

isVoid commented Oct 22, 2024

Discussed with @gmarkall offline. This PR is actually enabling lto for CUSource inputs, and a test should be added for that. Besides, because numba-cuda does not hard depend on pynvjitlink, and that pynvjitlink is required to enable LTO. We should keep LTO disabled by default. User can enable LTO via cuda.jit(lto=True). This control is still important because Numba users can be kernel developers that wants fine grain control over the compilation. In the future, we should consider using a global config to set LTO default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on author Waiting for author to respond to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants