Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kube Config Script for AWS EKS #4

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Conversation

angudadevops
Copy link
Collaborator

Hi @evberrypi

as setup-kube-config.sh not working properly removing now.

Thanks,
Anurag G

@evberrypi
Copy link
Collaborator

Can you re-generate the documentation in the readme? terraform-docs markdown . ?

@MaggieXJZhang
Copy link
Collaborator

Does this affect any steps in bring up the cluster? I only see removals of lines, but no edits to documentation.

@angudadevops
Copy link
Collaborator Author

@evberrypi done with terraform-docs markdown .

@MaggieXJZhang it's affecting ti bring up and destroying the cluster so removing that feature and updated the docs

Copy link
Collaborator

@evberrypi evberrypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @angudadevops

@evberrypi evberrypi merged commit c763dde into NVIDIA:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants