Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GKE README Instructions on Terraform Destroy #8

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update GKE README Instructions on Terraform Destroy #8

merged 1 commit into from
Sep 7, 2023

Conversation

MaggieXJZhang
Copy link
Collaborator

@MaggieXJZhang MaggieXJZhang commented Sep 7, 2023 •
edited
Loading

This PR modified two README files:

  1. The readme in GKE/examples/cnpack : had the incorrect tf destroy instructions and "beta" in the gcloud fetch cluster credentials command.
  2. The readme in main GKE had the rm gpu-operator namespace as a footnote, which many users failed to notice. I edited this section to reduce confusion.

@MaggieXJZhang MaggieXJZhang changed the title Update tf destroy with rm gpu operator namespace command Update GKE README Instructions on Terraform Destroy Sep 7, 2023
@MaggieXJZhang MaggieXJZhang self-assigned this Sep 7, 2023
@evberrypi evberrypi self-requested a review September 7, 2023 18:00
evberrypi
evberrypi approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@evberrypi evberrypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MaggieXJZhang MaggieXJZhang merged commit 920feb3 into main Sep 7, 2023
@MaggieXJZhang MaggieXJZhang deleted the magzhang/gke-cnpack-readme-fix branch September 7, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slbryson slbryson slbryson approved these changes

@evberrypi evberrypi evberrypi approved these changes

Assignees

@MaggieXJZhang MaggieXJZhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaggieXJZhang @slbryson @evberrypi