Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve conftest.sh Script #37

Merged
merged 3 commits into from
May 25, 2022
Merged

Improve conftest.sh Script #37

merged 3 commits into from
May 25, 2022

Conversation

Nitepone
Copy link
Contributor

  • Remove non-posix local usage
  • Remove trailing whitespace
  • Fix broken test caused by missing quotes

@CLAassistant
Copy link

CLAassistant commented May 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@PAR2020 PAR2020 added the Implemented Fixed, in test prior to release integration label May 24, 2022
@aritger aritger self-assigned this May 25, 2022
@aritger aritger merged commit af26e1e into NVIDIA:main May 25, 2022
@aritger
Copy link
Collaborator

aritger commented May 25, 2022

Thanks for the contribution. I've merged all three patches.
Sure enough, it looks like local isn't POSIX. The usage of local in conftest is pretty minor, so just removing the use of local as done in the first two commits seems simplest. Thanks.

@PAR2020 PAR2020 added this to the 515.48.07 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@aritger aritger

Labels
Implemented Fixed, in test prior to release integration
Projects
None yet
Milestone
515.48.07
Development

Successfully merging this pull request may close these issues.
4 participants
@Nitepone @CLAassistant @aritger @PAR2020