Add support for profiling hooks on CPU. #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the capability of profiling individual queries on CPU without prescribing the used profiling tools. Signed-off-by: Lukas Krenz <lkrenz@nvidia.com>
Signed-off-by: Lukas Krenz <lkrenz@nvidia.com>
abellina
reviewed
Nov 25, 2024
nds/nds_power.py
Outdated
|
|
||
| def __call__(self, query_name): | ||
| self.query_name = query_name | ||
| self.output_directory = os.path.join(self.output_root, query_name) |
There was a problem hiding this comment.
I think we should pass the output_root and query_name to the hook and let it decide how it wants to store (or IF it wants to store) in the file system. So the hook would need to mkdir in this case. Thoughts?
Script now can choose how to organize profiling. Signed-off-by: Lukas Krenz <lkrenz@nvidia.com>
|
Thanks for the review @abellina, I've followed your suggestion. Is there anything else that I could improve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of profiling individual queries on CPU without prescribing the used profiling tools.
The workflow is very simple.
The user provides a
--profiling-hook [executable]argument to nds_power.py. executable here is a script that gets called before and after each query. When the query starts, the first argument isstart, when it stops, the first argument isstop.For example, a user can decide to start perf, attach a profiler, etc.