Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] build-info fails for git worktrees outside the main local repo dir #2237

Closed
gerashegalov opened this issue Jul 18, 2024 · 0 comments · Fixed by #2238
Closed

[BUG] build-info fails for git worktrees outside the main local repo dir #2237

gerashegalov opened this issue Jul 18, 2024 · 0 comments · Fixed by #2238
Assignees
@gerashegalov
Labels
bug Something isn't working build

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug
If the developer adds a git worktree outside the main local repo the generated build version info properties file is corrupted

version=24.08.0-SNAPSHOT
user=doe
fatal: not a git repository: /home/doe/gits/NVIDIA/spark-rapids-jni.worktrees/test_rle/thirdparty/cudf/../../../../spark-rapids-jni/.git/worktrees/test_rle/modules/thirdparty/cudf
revision=
...

Steps/Code to reproduce bug

$ cd /path/spark-rapids-jni
$ git worktree add -b test_build_info_in_worktree ../spark-rapids-jni.worktrees/test_build_info_in_worktree
$ cd  ../spark-rapids-jni.worktrees/test_build_info_in_worktree
$ ./build/run-in-docker bash -c "$PWD/build/build-info 24.08.0-SNAPSHOT $PWD/thirdparty/cudf $PWD/target/libcudf/cmake-build/libcudf.a"

Expected behavior
First if the build info fails to generate the build should fail.
Second it should not fail.

Environment details (please complete the following information)
local docker

Additional context
N/A
@gerashegalov gerashegalov added bug Something isn't working build ? - Needs Triage labels Jul 18, 2024
gerashegalov added a commit to gerashegalov/spark-rapids-jni that referenced this issue Jul 18, 2024
@gerashegalov
Mount workree common dir in build docker
fade31d 
Fixes NVIDIA#2237

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov mentioned this issue Jul 18, 2024
Merged
@gerashegalov gerashegalov self-assigned this Jul 18, 2024
gerashegalov added a commit that referenced this issue Jul 18, 2024
@gerashegalov @jlowe
Mount workree common dir in build docker (#2238)
22b4bdd 
* Mount workree common dir in build docker

Fixes #2237

Signed-off-by: Gera Shegalov <gera@apache.org>

* Update build/run-in-docker

Co-authored-by: Jason Lowe <jlowe@nvidia.com>

---------

Signed-off-by: Gera Shegalov <gera@apache.org>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mount worktree common dir in build docker gerashegalov/spark-rapids-jni
2 participants
@gerashegalov @sameerz