Remove build link from the pre-merge-CI workflow [skip ci] #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NvTimLiu
requested review from
jlowe,
gerashegalov,
revans2,
sameerz,
GaryShen2008,
yinqingh and
YanxuanLiu
GaryShen2008
reviewed
Apr 8, 2024
| } else { | ||
| // upload log only in case of build failure | ||
| def guardWords = ["gitlab.*?\\.com", "urm.*?\\.com"] | ||
| guardWords.add("nvidia-smi(?s)(.*?)(?=git)") // hide GPU info | ||
| guardWords.add("sc-ipp*") // hide cloud info | ||
| githubHelper.uploadLogs(this, env.JOB_NAME, env.BUILD_NUMBER, null, guardWords) | ||
|
|
||
| githubHelper.updateCommitStatus("$BUILD_URL", "Fail", GitHubCommitState.FAILURE) | ||
| githubHelper.updateCommitStatus("", "Fail", GitHubCommitState.FAILURE) | ||
| } |
There was a problem hiding this comment.
One question about the failed build link, are we still linking to the uploaded log?
There was a problem hiding this comment.
Oh I did not realize it a little diff from spark-rapids log uploading: NVIDIA/spark-rapids#10664 (comment)
Let me double check it.
There was a problem hiding this comment.
Build PASS:
FAILED LOG uploaded:
FAILED log uploaded: https://github.com/NVIDIA/spark-rapids-jni/actions/runs/8613010813/job/23603450936
|
build |
Signed-off-by: Tim Liu <timl@nvidia.com>
|
build |
1 similar comment
|
build |
|
convert to draft to check failure log uploading |
|
build |
2 similar comments
|
build |
|
build |
NvTimLiu
changed the title
|
build |
jlowe
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove all the CI job's link from the pre-merge-CI workflow