Update JNI build to support nvcomp4 #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxLi@nyu.edu> Co-authored-by: Yinqing Hao <haoyinqing@gmail.com>
|
re-target to 24.10 and waiting for cudf updates |
|
will update submodule ref to include change at rapidsai/cudf#16076 when available |
|
@pxLi The cuDF work to support nvcomp 4.0.1 is now complete: rapidsai/cudf#16076 This should be ready to update the submodule ref now. |
pxLi
force-pushed
the
JNI-to-support-nvcomp4
branch
2 times, most recently
from
3c5d619
to
2807d99
Compare
pxLi
force-pushed
the
JNI-to-support-nvcomp4
branch
from
2807d99
to
f85ffeb
Compare
|
build |
GaryShen2008
approved these changes
Sep 6, 2024
gerashegalov
added a commit
to gerashegalov/spark-rapids-jni
that referenced
this pull request
Oct 2, 2024
This reverts commit 0bbefc0.
NvTimLiu
pushed a commit
to NvTimLiu/spark-rapids-jni
that referenced
this pull request
Oct 11, 2024
This reverts commit 0bbefc0.
pxLi
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Revert "Update JNI build to support nvcomp4 (#2217)" This reverts commit 0bbefc0. * Version * Apply and remove patches to CUDF as part of the build Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> * Better checking if git is dirty * Some review comments * Get submodule sync to work Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> --------- Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> Co-authored-by: Gera Shegalov <gera@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on rapidsai/cudf#16076
NOTE: We must update the submodule ref in this change once above gets merged.