Rename function and class containing from_json
#2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
revans2
reviewed
Aug 19, 2024
There was a problem hiding this comment.
The change looks fine. My main concern is that we are going to break the plugin. Could you please keep MapUtils.java with the extractRawMapFromJsonString but have it call into JSONUtils.java's extractRawMapFromJsonString? But because of how the plugin works we cannot deprecate the MapUtils API. But we can delete it as soon as the plugin is updated to use the new API.
|
build |
That sounds good. Now we have |
revans2
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few changes for
from_jsonfunction:from_jsonintofrom_json_to_raw_map, since the current implementation is not a full-featurefrom_json.MapUtilsintoJSONUtils, since JSON is more relevant than map.Moving away from
Map*intoJSON*is necessary for further development offrom_jsonto support more output data types other than just map.To avoid breaking changes in the Spark plugin, the function
MapUtils#extractRawMapFromJsonStringis redirected toJSONUtils#extractRawMapFromJsonString. The entire classMapUtilswill be removed in the follow up work.