Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Qualification should treat promote_precision as supported #517

Closed
amahussein opened this issue Aug 29, 2023 · 0 comments · Fixed by #545
Closed

[BUG] Qualification should treat promote_precision as supported #517

amahussein opened this issue Aug 29, 2023 · 0 comments · Fixed by #545
Assignees
@amahussein
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@amahussein
Copy link
Collaborator

amahussein commented Aug 29, 2023 •
edited
Loading

Describe the bug

Quoting @nartal1

promote_precision is shown as Not supported expression. Should fix this as it is supported.

EDIT:
The bug is due to missing SQL Func column. See NVIDIA/spark-rapids#9201
@amahussein amahussein added bug Something isn't working ? - Needs Triage core_tools Scope the core module (scala) labels Aug 29, 2023
@amahussein amahussein mentioned this issue Aug 29, 2023
Closed
This was referenced Sep 6, 2023
Closed
Open
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Sep 7, 2023
@amahussein
Qualification should treat promote_precision as supported
a0d70f4 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#517

- Added column value `promote_precision` to `SQL Func`
- Added new unit test to verify that promote_precision is supported for
  Spark LT 3.4.0
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Sep 7, 2023
@amahussein
Qualification should treat promote_precision as supported
b2edf85 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#517

- Added column value `promote_precision` to `SQL Func`
- Added new unit test to verify that promote_precision is supported for
  Spark LT 3.4.0
@amahussein amahussein mentioned this issue Sep 7, 2023
Merged
amahussein added a commit that referenced this issue Sep 8, 2023
@amahussein
Qualification should treat promote_precision as supported (#545)
7982701 
* Qualification should treat promote_precision as supported

Fixes #517

- Added column value `promote_precision` to `SQL Func`
- Added new unit test to verify that promote_precision is supported for
  Spark LT 3.4.0

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

---------

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Qualification should treat promote_precision as supported amahussein/spark-rapids-tools
2 participants
@cindyyuanjiang @amahussein