-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor core to converge Qualification and Profiling Tools implementation #980
Labels
Comments
amahussein
added
feature request
New feature or request
core_tools
Scope the core module (scala)
labels
Apr 30, 2024
This is great. This refactoring was much needed to improve the maintainence. |
amahussein
added a commit
to amahussein/spark-rapids-tools
that referenced
this issue
May 1, 2024
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Contributes to NVIDIA#980 - this code change aims at using common logic to create and update the application info inside Tools.
amahussein
added a commit
that referenced
this issue
May 2, 2024
* Refactor AppBase to use common AppMetaData between Q/P tools Contributes to #980 --------- Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
amahussein
added a commit
to amahussein/spark-rapids-tools
that referenced
this issue
May 7, 2024
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Contributes to NVIDIA#980
amahussein
added a commit
that referenced
this issue
May 16, 2024
* Refactor TaskEnd to be accessible by Q/P tools Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Contributes to #980 * Add Stage Accumulables to the accumulable objects for Q tool Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> * Refactor the code to allow Qual tool to generate same CSV files as Prof Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> * Cleaning up some naming conventions Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> * Fix typo in job/stage qual agg metrics Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> * Remove redundant sort function in skewshuffle analyzer Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> * Fix typos and remove unused classes from ProfileClassWarehouse Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> --------- Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
Currently, both Qualification and Profiling tools have different data structure and different reporting output.
This issue is to track the refactor process to make both implementation common.
This is an important step toward adding heuristics as a postProcess phase to analysing the eventlogs
There are many benefits of doing so:
Tasks
The text was updated successfully, but these errors were encountered: