Hook up the auto tuner in the qualification tool #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
looking at test failures, |
nartal1
reviewed
May 25, 2024
core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AggRawMetricsResult.scala
Outdated
Show resolved
Hide resolved
amahussein
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hooks up the metrics to the auto tuner to allow it to run in the Qualification tool on CPU event logs and output valid recommendations. Most of them are the same as the profiling tool except for the metrics we look at for spill.
I didn't want to conflict with other changes going on with combined qual/profiling tool so some code here was copied and should eventually be made common or base classes between profiling and qualification. For instance the getDataSourceInfo and some of the information in QualAppSummaryInfoProvider.
There are some TODO comments in the autotuner which will be addressed in other heuristic issues under #907
The default gpu type for onprem was A100, I changed that to L4 but because we don't have speedup factors for l4 I added a new function to get the speedup factors from another one. This is meant to be temporary as we deprecate the use of these speedup factors anyway.