Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port QualX repo and add CLI for train #1076

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Port QualX repo and add CLI for train #1076

merged 4 commits into from
Jun 6, 2024

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Jun 6, 2024 •
edited by amahussein
Loading

Issue: #909, #1049

We want to import the training module from QualX and update the prediction code with latest changes. This was done in four steps.

Steps

  1. Import the source code and pretrained models as it as. Exclude these from pytest and flake8 linters.
  2. Make changes in the qualx files to connect them with tools.
  3. Make changes in the tools to use the latest changes in qualx.
  4. Add entry point for train by adding a new CMD for training.

This PR is merges the feature branch with above changes to dev. Refer to individual PRs for more details:

@parthosa
Copy updated qualx
757775e
@parthosa
Port training model code into user tools (#1060)
60dc191 
* Plug qualx files with tools

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

* Remove arguments for eventlog and input_dir in predict

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

* Handle optional dependencies and add copyrights

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

---------

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa
Update tools with latest qualx and add CLI for train (#1064)
4a1c992 
* Update tools with latest qualx and add CLI for train

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

* Deprecate existing file and exclude qualx from pytest

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

* Fix typing for python3.8

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

* Update docs

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>

---------

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa
Add CLI for internal usage and update docs (#1075)
ce8e354 
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa parthosa added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Jun 6, 2024
@parthosa parthosa requested a review from amahussein June 6, 2024 00:34
@parthosa parthosa self-assigned this Jun 6, 2024
amahussein
amahussein approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parthosa
LGTME

@parthosa parthosa merged commit 39d7854 into dev Jun 6, 2024
16 checks passed
@parthosa parthosa deleted the spark-rapids-tools-1049-base branch June 6, 2024 15:07
@parthosa parthosa mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amahussein amahussein amahussein approved these changes

Assignees

@parthosa parthosa

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthosa @amahussein