Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix signature error from overlapping merges #1084

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix signature error from overlapping merges #1084

merged 1 commit into from
Jun 7, 2024

Conversation

leewyang
Copy link
Collaborator

@leewyang leewyang commented Jun 7, 2024

This PR fixes a method signature conflict introduced by overlapping merges in #1080 and #1083

Changes

  1. Add throwaway variable for extra output.

Test

Following CMDs have been tested:

Internal Usage:

python qualx_main.py evaluate

@leewyang
fix signature error from overlapping merges
df5b4e9 
Signed-off-by: Lee Yang <leewyang@gmail.com>
@leewyang leewyang requested a review from parthosa June 7, 2024 00:20
@leewyang leewyang merged commit 46ac6b0 into NVIDIA:dev Jun 7, 2024
16 checks passed
@leewyang leewyang deleted the qualx_fix_sig branch June 7, 2024 00:31
@amahussein amahussein added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

Assignees

@leewyang leewyang

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leewyang @parthosa @amahussein