Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the spark_rapids bootstrap command #1114

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Disable the spark_rapids bootstrap command #1114

merged 2 commits into from
Jun 13, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

Fixes #1103

Remove the bootstrap cmd from spark_Rapids cmd line

Note that internally, we can spark_rapids_user_tools to run the boostrap cmd.
This PR removes the cmd from spark_Rapids, and the markdown documents.
I will file an internal PR to remove the bootstrap tests from the CI/CD

@amahussein
Disable the spark_rapids bootstrap command
0bc49a8 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#1103

Renove the bootstrap cmd from spark_Rapids cmd line
@amahussein amahussein added feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Jun 12, 2024
@amahussein amahussein self-assigned this Jun 12, 2024
@amahussein amahussein added usability track issues related to the Tools's user experience labels Jun 12, 2024
nartal1
nartal1 previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein ! LGTM.

parthosa
parthosa previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein. LGTM.

@cindyyuanjiang cindyyuanjiang self-requested a review June 13, 2024 18:44
cindyyuanjiang
cindyyuanjiang reviewed Jun 13, 2024
View reviewed changes
user_tools/docs/index.md
@@ -89,9 +79,6 @@ The following table summarizes the commands supported for each cloud platform:
| | profiling | spark_rapids_user_tools \ | 23.02.1+ |
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove bootstrap from EMR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

cindyyuanjiang
cindyyuanjiang previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein! A minor nit.

@amahussein
remove bootstrap from EMR CLI
b3e65c4 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
cindyyuanjiang
cindyyuanjiang approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein!

@tgravescs
Copy link
Collaborator

if user tries to specify it, tool outputs command not found or something useful?

@amahussein
Copy link
Collaborator Author

if user tries to specify it, tool outputs command not found or something useful?

yes, that's supported by the Python CLI itself

Sample:

$> spark_rapids bootstrap
********************************************************************
*                                                                  *
*    _____                  __      ____              _     __     *
*   / ___/____  ____ ______/ /__   / __ \____ _____  (_)___/ /____ *
*   \__ \/ __ \/ __ `/ ___/ //_/  / /_/ / __ `/ __ \/ / __  / ___/ *
*  ___/ / /_/ / /_/ / /  / ,<    / _, _/ /_/ / /_/ / / /_/ (__  )  *
* /____/ .___/\__,_/_/  /_/|_|  /_/ |_|\__,_/ .___/_/\__,_/____/   *
*     /_/__  __                  ______    /_/     __              *
*       / / / /_______  _____   /_  __/___  ____  / /____          *
*      / / / / ___/ _ \/ ___/    / / / __ \/ __ \/ / ___/          *
*     / /_/ (__  )  __/ /       / / / /_/ / /_/ / (__  )           *
*     \____/____/\___/_/       /_/  \____/\____/_/____/            *
*                                                                  *
*                                      Version. 24.04.1            *
*                                                                  *
* NVIDIA Corporation                                               *
* spark-rapids-support@nvidia.com                                  *
********************************************************************


ERROR: Could not consume arg: bootstrap
Usage: spark_rapids <command>
  available commands:    prediction | profiling | qualification | train

For detailed information on this command, run:
  spark_rapids --help

@amahussein amahussein merged commit f720b07 into NVIDIA:dev Jun 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyyuanjiang cindyyuanjiang cindyyuanjiang approved these changes

@parthosa parthosa parthosa left review comments

@mattahrens mattahrens Awaiting requested review from mattahrens

@nartal1 nartal1 Awaiting requested review from nartal1

Assignees

@amahussein amahussein

Labels
feature request New feature or request usability track issues related to the Tools's user experience user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Disable the spark_rapids bootstrap command
5 participants
@amahussein @tgravescs @parthosa @cindyyuanjiang @nartal1