[FEA] Display full failure messages in failed CSV files #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Fixes NVIDIA#1132 This commit changes the output CSV fiules failed_* . The new format will have the entire failure reason for jobs/stages/tasks if any. - The content of the failureReason is escaped. It will show as a single line. - Moved `escapeMetaCharacters` to StringUtils - Moved `ProfileUtils.truncateFailureStr` to StringUtils and renamed it to `renderStr` - Fixed a couple of inconsistency in formatting the strings - Updated the UnitTests - TODO: File a followup revisiting `reformatCSVString` to use `renderStr`
amahussein
added
feature request
This was referenced Jun 24, 2024
wjxiz1992
approved these changes
Jun 25, 2024
tgravescs
reviewed
Jun 25, 2024
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/StringUtils.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Jun 25, 2024
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/StringUtils.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Jun 25, 2024
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/StringUtils.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Jun 25, 2024
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/StringUtils.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
tgravescs
previously approved these changes
Jun 25, 2024
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
tgravescs
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
Fixes #1132
This commit changes the output CSV files failed_* . The new format will have the entire failure reason for jobs/stages/tasks if any.
escapeMetaCharactersto StringUtilsProfileUtils.truncateFailureStrto StringUtils and renamed it torenderStrreformatCSVStringto userenderStr: followup issue [FEA] Revisit string formats in tools #1136