Fix parsing App IDs inside metrics directory in QualX #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
parthosa
added
bug
parthosa
changed the title
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
amahussein
approved these changes
Jul 5, 2024
Comment on lines
+445
to
+447
| # search sub directories for App IDs | ||
| app_ids = [p.name for p in Path(metrics_dir).iterdir() if p.is_dir()] | ||
| if len(app_ids) == 0: |
There was a problem hiding this comment.
This fix should do it.
The trick part in this change that we have to rely on directory structure to pick the right folders.
For example, moving fwd, we can't introduce a subdirectory in raw-metrics because it will be mistakenly treated as an Application folder.
There was a problem hiding this comment.
Thanks @amahussein. Yes, If we change the raw metrics folder then all its usages should be updated as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1163. QualX assumes App IDs start with
app*and uses this regex pattern to fetch profiling metrics. However, App IDs can be any alphanumeric string.This PR fixes the parsing to read all subdirectories and create the list. We are guaranteed that all sub directories within
raw_metricscontain individual app metrics so we do not need a regex matching and can safely read all of them.