Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-tools:Update --help for cluster argument #1178

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Jul 10, 2024

This contributes to #1144

This is a minor PR where --help returns better explanation for --cluster argument. Earlier it wasn't clear if the cluster is the target cluster or CPU cluster that the Spark applications were run.

spark_rapids qualification --help

Earlier output:

  --cluster=CLUSTER
        Type: Optional[str]
        Default: None
        Name or ID (for databricks platforms) of cluster or path to cluster-properties.

In this PR:

--cluster=CLUSTER
        Type: Optional[str]
        Default: None
        The CPU cluster on which the Spark applications were executed. Name or ID (for databricks platforms) of cluster or path to cluster-properties.

Pending: Create MR to update it in documentation.

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 added the documentation Improvements or additions to documentation label Jul 10, 2024
@nartal1 nartal1 self-assigned this Jul 10, 2024
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1. We should also file an MR to update the docs.

Co-authored-by: Thomas Graves <tgraves@apache.org>
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1 !

This contributes to #1144

What else is gonna be needed to fix 1144? It will be nice to update the issue description adding subtasks if any so that next followups will be well defined.

@nartal1
Copy link
Collaborator Author

nartal1 commented Jul 10, 2024

What else is gonna be needed to fix 1144? It will be nice to update the issue description adding subtasks if any so that next followups will be well defined.

Thanks @amahussein ! I was planning to close it after merging the documentation changes. Updated the description and added the subtasks in the issue.

Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1
LGTME

@nartal1 nartal1 merged commit ae5c917 into NVIDIA:dev Jul 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants