Update pre-commit hooks to check for headers and white-spaces #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Contributes to NVIDIA#1158 - add trailing-whitespace check to the pre-commit hooks to avoid whitespaces at the end of lines - add E-O-F fixer to make sure that only a single newline is at the end of each committed file - added a script to check that newly added files have the header. - pulled the intelli-j idea from RAPIDS plugin and update the the README file. No link is added because the markdown checker could cause the build to fail until a release is made.
2 tasks
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
parthosa
reviewed
Jul 19, 2024
core/README.md
Outdated
|
|
||
| ### Setting up an Integrated Development Environment | ||
|
|
||
| Before proceeding with importing spark-rapids into IDEA or switching to a different Spark release |
core/README.md
Outdated
| ##### Importing the project | ||
|
|
||
| To start working with the project in IDEA is as easy as importing the project as a Maven project. | ||
| Select the profile used in the mvn command above, e.g. `spark340` for Spark 3.4.0. |
There was a problem hiding this comment.
nit: Can we keep all versions to 3.5.0 since that is the default for our repo.
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
| ### Setting up an Integrated Development Environment | ||
|
|
||
| Before proceeding with importing spark-rapids-tools into IDEA or switching to a different Spark release | ||
| profile, execute the install phase with the corresponding `buildver`, e.g. for Spark 3.5.0: |
There was a problem hiding this comment.
nit: "e.g. for Spark 3.5.0", should be "e.g. 350 for Spark 3.5.0"?
cindyyuanjiang
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
Contributes to #1158