Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header check script to exclude files #1224

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix header check script to exclude files #1224

merged 2 commits into from
Jul 24, 2024

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Jul 23, 2024

This is a bug fix in the script where the directories were not excluded correctly. This bug is from my previous PR #1219 where I had not checked if it excludes all the directories correctly.
The error was as below:

Checking new file: scripts/header-check.sh
grep: core/src/test/resources/*,: No such file or directory
grep: user_tools/src/spark_rapids_pytools/resources/*,: No such file or directory

This PR fixes above issue. Verified this locally.

@nartal1
Fix header check script to exclude files
575a1e8 
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 added bug Something isn't working build labels Jul 23, 2024
@nartal1 nartal1 requested a review from amahussein July 23, 2024 23:16
@nartal1 nartal1 self-assigned this Jul 23, 2024
@nartal1
Copy link
Collaborator Author

nartal1 commented Jul 23, 2024

@amahussein - Please take a look. I introduced this bug in my previous PR. I tested it on a branch with the new files already added, so it wasn't caught during testing.

@parthosa parthosa self-requested a review July 23, 2024 23:45
parthosa
parthosa reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1. Tested the functionality. Minor comment.

scripts/header-check.sh Outdated Show resolved Hide resolved
amahussein
amahussein previously approved these changes Jul 24, 2024
View reviewed changes
@nartal1
addressed review comment
21b19ec 
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
parthosa
parthosa approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1 for making the review changes.

@nartal1 nartal1 merged commit dfaeada into NVIDIA:dev Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@amahussein amahussein amahussein left review comments

Assignees

@nartal1 nartal1

Labels
bug Something isn't working build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nartal1 @parthosa @amahussein