Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace split_nds with split_train_val #1252

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

leewyang
Copy link
Collaborator

@leewyang leewyang commented Aug 2, 2024

This PR replaces the split_nds function with a more generic split_train_val function. This avoids having any dataset-specific split functions in the core qualx code, and pushes them to the dataset-specific plugins.

I have confirmed that this produces identical models when paired w/ a new nds.py plugin in the internal repo.

Test

Following CMDs have been tested.

Internal Usage:

python qualx_main.py preprocess
python qualx_main.py train
python qualx_main.py evaluate

Signed-off-by: Lee Yang <leewyang@gmail.com>
@leewyang leewyang self-assigned this Aug 2, 2024
@leewyang leewyang added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Aug 2, 2024
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leewyang. LGTM. Small question:

What does this refer to?

pushes them to the dataset-specific plugins

@leewyang
Copy link
Collaborator Author

leewyang commented Aug 2, 2024

@parthosa basically, some datasets require custom logic for determining train/test splits, e.g. we use a fixed/curated list of queries for NDS. This logic is now moved to a plugin that gets loaded per this code.

@leewyang leewyang merged commit 31b82d1 into NVIDIA:dev Aug 2, 2024
15 checks passed
@leewyang leewyang deleted the qualx_split_nds branch August 2, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants