Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cluster shape columns to use 'worker' prefix in the output files and rename metadata file #1258

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Aug 5, 2024

Issue: #1239

Changes

  • Rename all cluster shape related columns/fields to use worker prefix instead of executor.
    • Usage of executorInstance, driverInstance has been replaced by workerNodeType and driverNodeType
    • Going forward we should ensure executor term is reserved only for spark executors to avoid ambiguity.
  • Renames metadata file to app_metadata.json
    • Add platform field in the metadata file

Output

File: qual_2024xxx/app_metadata.json

Contents
[
  {
    "appId": "application_1692643187882_0001",
    "appName": "NDS - Power Run",
    "eventLog": "file:/path/application_1692643187882_0001",
    "clusterInfo": {
      "platform": "emr",
      "sourceCluster": {
        "driverNodeType": "i3.2xlarge",
        "workerNodeType": "m5d.8xlarge",
        "numWorkerNodes": 8
      },
      "recommendedCluster": {
        "driverNodeType": "i3.2xlarge",
        "workerNodeType": "g5.4xlarge",
        "numWorkerNodes": 16
      }
    },
    "estimatedGpuSpeedupCategory": "Small",
    "fullClusterConfigRecommendations": "/tool_output/qual_20240805173341_9Eb76BAa/rapids_4_spark_qualification_output/tuning/application_1692643187882_0001.conf",
    "gpuConfigRecommendationBreakdown": "/tool_output/qual_20240805173341_9Eb76BAa/rapids_4_spark_qualification_output/tuning/application_1692643187882_0001.log"
  }
]

File: qual_2024xxx/rapids_4_spark_qualification_output/rapids_4_spark_qualification_output_cluster_information.json

Contents
[ {
  "appName" : "NDS - Power Run",
  "appId" : "application_1692643187882_0001",
  "eventLogPath" : "file:/path/application_1692643187882_0001",
  "clusterInfo" : {
    "vendor" : "emr",
    "coresPerExecutor" : 16,
    "numExecsPerNode" : 2,
    "numWorkerNodes" : 8,
    "executorHeapMemory" : 16384,
    "driverHost" : "ip-xxx.us-west-2.compute.internal",
    "clusterId" : "j-2xxxx"
  },
  "recommendedClusterInfo" : {
    "vendor" : "emr",
    "coresPerExecutor" : 16,
    "numWorkerNodes" : 16,
    "numGpus" : 1,
    "numExecutors" : 16,
    "workerNodeType" : "g5.4xlarge"
  }
} ]

Follow Up PR

  • Add cluster recommendation for onprem
  • Ensure correct gpuPerWorker is recommended for eligible platforms (dataproc, onprem)

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa parthosa added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) core_tools Scope the core module (scala) labels Aug 5, 2024
@parthosa parthosa self-assigned this Aug 5, 2024
@parthosa parthosa marked this pull request as ready for review August 5, 2024 17:53
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parthosa!

@parthosa parthosa merged commit 3662a99 into NVIDIA:dev Aug 5, 2024
15 checks passed
@parthosa parthosa deleted the spark-rapids-tools-1239 branch August 5, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala) user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants