Do not create new StageInfo object #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
amahussein
reviewed
Aug 5, 2024
| @@ -54,7 +55,7 @@ class StageModel private(sInfo: StageInfo) { | |||
| stubStage.submissionTime = newStageInfo.submissionTime | |||
| stubStage.failureReason = newStageInfo.failureReason | |||
| stubStage | |||
| } | |||
| }*/ | |||
There was a problem hiding this comment.
We can remove it completely
or just return the same newStageInfo. This will be more consistent with avoiding dead leaving dead code around.
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
changed the title
amahussein
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #1260
In this PR, we do not create the new StageInfo object. Instead we return newStageInfo itself.