Remove legacy SpeedupFactor from core output files #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein <ahussein@nvidia.com> Contributes to NVIDIA#1199 Remove legacy speedup columns from core tools output files. This does not address removing fields from AppSummaryInfo which requires extensive code cleanup - `rapids_4_spark_qualification_output.csv` - `Estimated GPU Speedup` - `Task Speedup Factor` - `Recommendation` - `rapids_4_spark_qualification_output_execs.csv` - `Task Speedup Factor` - `rapids_4_spark_qualification_output_stages.csv` - `Average Speedup Factor` - `rapids_4_spark_qualification_output_persql.csv` - `Recommendation` - `Estimated GPU Speedup`
amahussein
added
core_tools
|
this seems to be in draft what is left here? |
Making some fixes on the Python Qualx side that should not affect the Scala changes. |
Signed-off-by: Lee Yang <leewyang@gmail.com>
parthosa
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Thanks @amahussein. LGTME.
From our offline discussion:
- In python, we replace the legacy col
ESTIMATED_GPU_DURATIONfrom scala byappDuration_predfrom qualx and recalculateESTIMATED_GPU_TIMESAVED. - We should remove these legacy GPU cols as well. This could be a follow PR.
parthosa
approved these changes
Aug 29, 2024
|
Thanks @leewyang for adding the patch removing unnecessary reads from the core's output. |
cindyyuanjiang
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Thanks Ahmed! There may be some merge conflicts with #1320 depending on which PR goes in first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein ahussein@nvidia.com
Contributes to #1199
Remove legacy speedup columns from core tools output files. This does not address removing fields from AppSummaryInfo which requires extensive code cleanup
rapids_4_spark_qualification_output.csvEstimated GPU SpeedupTask Speedup FactorRecommendationrapids_4_spark_qualification_output_execs.csvTask Speedup Factorrapids_4_spark_qualification_output_stages.csvAverage Speedup Factorrapids_4_spark_qualification_output_persql.csvRecommendationEstimated GPU Speedup