Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark RunningWindowFunction as supported in Qual tool #1465

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

Fix #1460

RunningWindowFunction should be marked as supported by the qualification tool.

This a Databricks exec that we cannot verify in unit tests without DB runtime dependencies.

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fix NVIDIA#1460

`RunningWindowFunction` should be marked as supported by the
qualification tool.
@amahussein amahussein added the core_tools Scope the core module (scala) label Dec 13, 2024
@amahussein amahussein self-assigned this Dec 13, 2024
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @amahussein !

Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein!

@amahussein amahussein merged commit 9564d0b into NVIDIA:dev Dec 16, 2024
16 checks passed
@amahussein amahussein deleted the rapids-tools-1460 branch December 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RunningWindowFunction should be marked as supported by QualificationTool
3 participants