Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Up: Make '--platform' argument mandatory in CLI #1473

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

parthosa
Copy link
Collaborator

Fixes #1472.

This PR ensures that the --help output for the CLI command reflects the --platform parameter as mandatory.

Current Behavior

Running the command spark_rapids qualification -- --help incorrectly shows the platform argument as optional:

 -p, --platform=PLATFORM
        Type: Optional[str]
        Default: None
        defines one of the following "onprem", "emr", "dataproc", "dataproc-gke", "databricks-aws", and "databricks-azure".

After this PR

    -p, --platform=PLATFORM (required)
        Type: str
        Defines one of the following: "onprem", "emr", "dataproc", "dataproc-gke", "databricks-aws", and "databricks-azure".

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa parthosa added the bug Something isn't working label Dec 19, 2024
@parthosa parthosa requested a review from amahussein December 19, 2024 18:55
@parthosa parthosa self-assigned this Dec 19, 2024
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa parthosa marked this pull request as ready for review December 19, 2024 20:28
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parthosa
LGTME

@parthosa parthosa merged commit f0058c0 into NVIDIA:dev Dec 20, 2024
15 checks passed
@parthosa parthosa deleted the spark-rapids-tools-1472 branch December 20, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Followup: Make '--platform' argument mandatory in CLI to prevent incorrect behavior
2 participants