Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoTuner does not process arguments skipList and limitedLogic #812

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

Fixes #811

AutoTuner.getRecommendedProperties does not process the arguments correctly which results skipping the concatenation of the arguments into the global fields.

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#811

`AutoTuner.getRecommendedProperties` does not process the arguments
correctly which results skipping the concatenation of the arguments into
the global fields.
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amahussein amahussein merged commit fe1e59c into NVIDIA:dev Feb 27, 2024
14 checks passed
@amahussein amahussein deleted the spark-rapids-tools-811 branch February 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AutoTuner does not process arguments skipList and limitedLogic
2 participants