Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action column to qual execs output #859

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add action column to qual execs output #859

merged 2 commits into from
Mar 21, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

Fixes #858

  • Adds "Action" column to the
    rapids_4_spark_qualification_output_execs.csv. When the exec is supported the action is set to NONE
  • Did some cleanups in the QualOutputWriter as the report generator was traversing the execs list twice and trying to flatten execs that were already flatten.

@amahussein
Add action column to qual execs output
29d5358 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#858

Adds "Action" column to the
`rapids_4_spark_qualification_output_execs.csv`. When the exec is
supported the action is set to `NONE`
@amahussein amahussein added feature request New feature or request core_tools Scope the core module (scala) labels Mar 20, 2024
@amahussein amahussein self-assigned this Mar 20, 2024
@amahussein amahussein requested a review from nartal1 March 20, 2024 21:36
@amahussein
remove execToExpr map from qualificationInfo
44a5bf6 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
nartal1
nartal1 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @amahussein !

@nartal1 nartal1 merged commit 0345898 into NVIDIA:dev Mar 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

Assignees

@amahussein amahussein

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add action column to qual execs output
2 participants
@amahussein @nartal1