Add Support for BloomFilterAggregate and BloomFilterMightContain exprs #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Contributes to NVIDIA#865 This PR adds support to two new expressions for the bloomFilter - Adds a new test case to check that the expressions are parsed correctly
amahussein
added
bug
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
nartal1
previously approved these changes
Apr 1, 2024
| @@ -265,3 +265,5 @@ MapInPandasExec,1.2 | |||
| WindowInPandasExec,1.2 | |||
| RoundCeil,3.65 | |||
| RoundFloor,3.65 | |||
| BloomFilterMightContain,3.16 | |||
| BloomFilterAggregate,3.16 | |||
There was a problem hiding this comment.
Why is this 3.16 but other operator scores are 3.65?
There was a problem hiding this comment.
Good catch @cindyyuanjiang ! I fixed it.
That's a default value. So, it won't matter.
But you are right that it should match the change we do in other files to be consistent.
parthosa
previously approved these changes
Apr 1, 2024
cindyyuanjiang
requested changes
Apr 1, 2024
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
cindyyuanjiang
approved these changes
Apr 2, 2024
nartal1
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
Contributes to #865
This PR adds support to two new expressions for the bloomFilter