Add support for KnownNullable and EphemeralSubstring expressions #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Contributes to NVIDIA#865 Adds support to two new string expressions - `EphermalSubstring` is supported by DB, but we add it to the score sheet of all other platforms since we have a single expression.csv file anyway. - No need for a new unit test for `EphermalSubstring` because it is the same as substring. - Added a new test for `KnownNullable` - Removed configuration override related to `Empty2Null` because the sql function is the lower string of the expr-name which should be supported by default. - Removed the entries of the expressions in `override_supported_configs.json`
amahussein
added
bug
amahussein
changed the title
parthosa
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
Contributes to #865
Adds support to two new string expressions
EphermalSubstringis supported by DB, but we add it to the score sheet of all other platforms since we have a single expression.csv file anyway.EphermalSubstringbecause it is the same as substring.KnownNullableEmpty2Nullbecause the sql function is the lower string of the expr-name which should be supported by default.override_supported_configs.json