Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AtomicCreateTableAsSelectExec #895

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add support for AtomicCreateTableAsSelectExec #895

merged 2 commits into from
Apr 3, 2024

Commits on Apr 2, 2024

  1. Add support for AtomicCreateTableAsSelectExec 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#881

- update the support level for existing Execs such as OverwriteByExpr,
  AppendDataExecV1, AtomicReplaceTableAsSelect
- The Op is mainly support if the provider is Delta. Otherwise, the GPU
  should fallback to CPU.
- We check if the provider is Delta by matching regex on node
  description. Ideally we should check the secondArgument of TableSpec
but we don't have an AST for that expression.
- Updates the score sheets assigning a default score as DataWritingCmd
- Fixes hardcoded exec. Before that change, all writeCMDs mapped to
  DataWringCMDExec. This code changes that behavior when the Delta
provider is satisfied.
- updates the override_supported_configs.json file
    @amahussein
    amahussein committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    086f293 View commit details
    Browse the repository at this point in the history

  2. Fix scala styling 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6720443 View commit details
    Browse the repository at this point in the history