Add support for PythonMapInArrowExec and MapInArrowExec #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
parthosa
added
bug
amahussein
requested changes
Apr 9, 2024
There was a problem hiding this comment.
I filed an audit issue NVIDIA/spark-rapids#10673 to be aware of the className change
On the tools side, Lets add MapInArrowExec/MapInArrow in this PR so we can be compatible with spark-4 waiting for the plugin to extend the shims.
Don't forget to add it to the score sheets.
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Outdated
Show resolved
Hide resolved
amahussein
reviewed
Apr 9, 2024
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/PythonMapInArrowExecParser.scala
Show resolved
Hide resolved
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
amahussein
changed the title
amahussein
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884. This PR adds support for
PythonMapInArrowExecin tools.Note: For Spark 4.0, we might have to revisit as this exec is renamed to
MapInArrowExec.Spark Commit: apache/spark@ed9a3a8