-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster details in qualification summary output #921
Conversation
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Some Design Questions
|
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@@ -370,12 +369,6 @@ def check_discount_percentage(discount_type: str, discount_value: int): | |||
self.ctxt.set_ctxt('cpu_discount', cpu_discount) | |||
self.ctxt.set_ctxt('gpu_discount', gpu_discount) | |||
|
|||
def _create_cluster_report_args(self) -> list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required any more since we want to generate cluster information in every case.
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa
We discussed offline the design questions.
LGTME
Fixes #918. This PR adds columns
Vendor
,Driver Host
,Cluster ID
,Cluster Name
in the user tools qualification summary. This will assist the customers distinguish different jobs especially when in Databricks where all applications have the same name.User Tools Output:
File: qualification_summary.csv
Note:
App Name
, we will group by[Vendor,Driver Host,Cluster ID,Cluster Name,App Name]
Top Candidates
view shows meaningful resultsHow To Test
spark_rapids qualification --platform $PLATFORM --eventlogs $EVENTLOGS --tools_jar $SPARK_RAPIDS_TOOLS_DEV_JAR