Followups on handling Photon eventlogs #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Fixes NVIDIA#948 - this change makes the Qualification detect photon eventlogs fron environmentUpdate event - Adds a boolean that will be used later for applications with photon runtime in Prof/Qual tools - Moved some of the utilities to the new class DatabricksParseHelper - Fixed a bug in handling incorrect App parsing - Fixed unit tests
amahussein
added
bug
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/DatabricksParseHelper.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/ToolUtils.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationAppInfo.scala
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/qualification/AppFilterSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/qualification/AppFilterSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
amahussein
commented
Apr 22, 2024
core/src/test/scala/com/nvidia/spark/rapids/tool/qualification/AppFilterSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/qualification/AppFilterSuite.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/ToolUtils.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/DatabricksParseHelper.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationAppInfo.scala
Show resolved
Hide resolved
parthosa
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Thanks @amahussein for this change. Minor typo nit. Removing the hardcoded strings was a good idea.
|
|
||
| /** | ||
| * Checks if the properties indicate that the application is a Photon app. | ||
| * This ca be checked by looking for keywords in one of the keys defined in PHOTON_SPARK_PROPS |
cindyyuanjiang
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
Fixes #948