Resolve comments

NVIDIA · Sep 13, 2021 · a37a3ee · a37a3ee
1 parent fce9b45
commit a37a3ee
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/Spark320Shims.scala b/shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/Spark320Shims.scala
@@ -497,9 +497,8 @@ class Spark320Shims extends Spark32XShims {
             Seq(GpuOverrides.wrapScan(p.scan, conf, Some(this)))
 
           override def tagPlanForGpu(): Unit = {
-            // Only Scan with SupportsRuntimeFiltering can support DPP.
             if (!p.runtimeFilters.isEmpty) {
-              willNotWorkOnGpu("The DPP has not been supported")
+              willNotWorkOnGpu("Runtime filtering (DPP) on datasource V2 is not supported")
             }
           }
 
@@ -515,8 +514,10 @@ class Spark320Shims extends Spark32XShims {
       (a, conf, p, r) => new ScanMeta[ParquetScan](a, conf, p, r) {
         override def tagSelfForGpu(): Unit = {
           GpuParquetScanBase.tagSupport(this)
+          // we are being overly cautious and that Parquet does not support this yet
           if (a.isInstanceOf[SupportsRuntimeFiltering]) {
-            willNotWorkOnGpu("DPP has not been supported by GPU ParquetScan")
+            willNotWorkOnGpu("Parquet does not support Runtime filtering (DPP)" +
+              " on datasource V2 yet.")
           }
         }
 
@@ -539,8 +540,10 @@ class Spark320Shims extends Spark32XShims {
       (a, conf, p, r) => new ScanMeta[OrcScan](a, conf, p, r) {
         override def tagSelfForGpu(): Unit = {
           GpuOrcScanBase.tagSupport(this)
+          // we are being overly cautious and that Orc does not support this yet
           if (a.isInstanceOf[SupportsRuntimeFiltering]) {
-            willNotWorkOnGpu("DPP has not been supported by GPU OrcScan")
+            willNotWorkOnGpu("Orc does not support Runtime filtering (DPP)" +
+              " on datasource V2 yet.")
           }
         }
 
@@ -562,8 +565,10 @@ class Spark320Shims extends Spark32XShims {
       (a, conf, p, r) => new ScanMeta[CSVScan](a, conf, p, r) {
         override def tagSelfForGpu(): Unit = {
           GpuCSVScan.tagSupport(this)
+          // we are being overly cautious and that Csv does not support this yet
           if (a.isInstanceOf[SupportsRuntimeFiltering]) {
-            willNotWorkOnGpu("DPP has not been supported by GPU CSVScan")
+            willNotWorkOnGpu("Csv does not support Runtime filtering (DPP)" +
+              " on datasource V2 yet.")
           }
         }