Address comments

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
NVIDIA · Jun 30, 2021 · e980afe · e980afe
1 parent 47d24a0
commit e980afe
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
@@ -1187,13 +1187,11 @@ object GpuOverrides {
     expr[Coalesce] (
       "Returns the first non-null argument if exists. Otherwise, null",
       ExprChecks.projectNotLambda(
-        (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() +
-          TypeSig.ARRAY + TypeSig.STRUCT,
+        _commonTypes.nested() + TypeSig.ARRAY + TypeSig.STRUCT,
         TypeSig.all,
         repeatingParamCheck = Some(RepeatingParamCheck("param",
-          (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() +
-            TypeSig.ARRAY + TypeSig.STRUCT,
-        TypeSig.all))),
+          _commonTypes.nested() + TypeSig.ARRAY + TypeSig.STRUCT,
+          TypeSig.all))),
       (a, conf, p, r) => new ExprMeta[Coalesce](a, conf, p, r) {
         override def convertToGpu(): GpuExpression = GpuCoalesce(childExprs.map(_.convertToGpu()))
       }),
@@ -1743,17 +1741,14 @@ object GpuOverrides {
     expr[If](
       "IF expression",
       ExprChecks.projectNotLambda(
-        (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() +
-          TypeSig.ARRAY + TypeSig.STRUCT,
+        _commonTypes.nested() + TypeSig.ARRAY + TypeSig.STRUCT,
         TypeSig.all,
         Seq(ParamCheck("predicate", TypeSig.BOOLEAN, TypeSig.BOOLEAN),
           ParamCheck("trueValue",
-            (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() +
-              TypeSig.ARRAY + TypeSig.STRUCT,
+            _commonTypes.nested() + TypeSig.ARRAY + TypeSig.STRUCT,
             TypeSig.all),
           ParamCheck("falseValue",
-            (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() +
-              TypeSig.ARRAY + TypeSig.STRUCT,
+            _commonTypes.nested() + TypeSig.ARRAY + TypeSig.STRUCT,
             TypeSig.all))),
       (a, conf, p, r) => new ExprMeta[If](a, conf, p, r) {
         override def convertToGpu(): GpuExpression = {