Skip to content

Commit

Permalink
Remove FETCH_TIME, use COLLECT_TIME instead (#2515)
Browse files Browse the repository at this point in the history
Signed-off-by: Andy Grove <andygrove@nvidia.com>
  • Loading branch information
andygrove authored Jun 3, 2021
1 parent 769a788 commit ea189f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -281,16 +281,16 @@ abstract class GpuColumnarToRowExecParent(child: SparkPlan, val exportColumnarRd
override lazy val allMetrics: Map[String, GpuMetric] = Map(
NUM_OUTPUT_ROWS -> createMetric(outputRowsLevel, DESCRIPTION_NUM_OUTPUT_ROWS),
OP_TIME -> createNanoTimingMetric(MODERATE_LEVEL, DESCRIPTION_OP_TIME),
FETCH_TIME -> createNanoTimingMetric(MODERATE_LEVEL, DESCRIPTION_FETCH_TIME),
COLLECT_TIME -> createNanoTimingMetric(MODERATE_LEVEL, DESCRIPTION_COLLECT_TIME),
NUM_INPUT_BATCHES -> createMetric(DEBUG_LEVEL, DESCRIPTION_NUM_INPUT_BATCHES))

override def doExecute(): RDD[InternalRow] = {
val numOutputRows = gpuLongMetric(NUM_OUTPUT_ROWS)
val numInputBatches = gpuLongMetric(NUM_INPUT_BATCHES)
val opTime = gpuLongMetric(OP_TIME)
val fetchTime = gpuLongMetric(FETCH_TIME)
val collectTime = gpuLongMetric(COLLECT_TIME)

val f = makeIteratorFunc(child.output, numOutputRows, numInputBatches, opTime, fetchTime)
val f = makeIteratorFunc(child.output, numOutputRows, numInputBatches, opTime, collectTime)

val cdata = child.executeColumnar()
if (exportColumnarRdd) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ object GpuMetric extends Logging {
val NUM_PARTITIONS = "numPartitions"
val TOTAL_TIME = "totalTime"
val OP_TIME = "opTime"
val FETCH_TIME = "fetchTime"
val PEAK_DEVICE_MEMORY = "peakDevMemory"
val COLLECT_TIME = "collectTime"
val CONCAT_TIME = "concatTime"
Expand All @@ -76,7 +75,6 @@ object GpuMetric extends Logging {
val DESCRIPTION_NUM_PARTITIONS = "partitions"
val DESCRIPTION_TOTAL_TIME = "total time"
val DESCRIPTION_OP_TIME = "op time"
val DESCRIPTION_FETCH_TIME = "fetch time"
val DESCRIPTION_PEAK_DEVICE_MEMORY = "peak device memory"
val DESCRIPTION_COLLECT_TIME = "collect batch time"
val DESCRIPTION_CONCAT_TIME = "concat batch time"
Expand Down

0 comments on commit ea189f2

Please sign in to comment.