Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] time zone checks for from_json are too broad and do not follow JsonScan #10453

Open
revans2 opened this issue Feb 21, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 21, 2024

Describe the bug
The code that checks time zones for JsonOptions, which is what is used by JsonScan looks specifically if a timestamp is being read, but there are other more generic checks for JsonToStructs where it just looks if a non-utc timezone is set or not. This makes it so we fall back for all situations where there is an unsupported timezone set, even if that timezone would never be used.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 21, 2024
@revans2 revans2 mentioned this issue Feb 26, 2024
62 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants