Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] StructsToJson does not fall back to the CPU for unsupported timeZone options #10486

Closed
revans2 opened this issue Feb 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 23, 2024

Describe the bug
Our current code to fall back to the CPU for unsupported time zones looks at the globally set time zone, or the one that is set specifically for an expression. But from_json has a text option that can be passed in that overrides all of them on how the timestamps should be interpreted.

We need to either support the time zone when parsing the timestamp or we need to fall back to the CPU for it.

I suspect this is also the case for ScanJson, but I don't have a test to verify that yet.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 23, 2024
@revans2 revans2 mentioned this issue Feb 26, 2024
62 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
@revans2
Copy link
Collaborator Author

revans2 commented Mar 14, 2024

The code was recently made common between JsonToStructs(from_json) and ScanJson so now the checks are the same and we do fall back if we are not in a UTC time zone when timestamps or dates are present in the read schema.

#10542

But from_json still has a bug where generic checks #10453.

@revans2 revans2 closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants