Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove the null replacement in GpuConditionalExpression #2468

Closed
firestarman opened this issue May 21, 2021 · 0 comments · Fixed by #2486
Closed

[FEA] Remove the null replacement in GpuConditionalExpression #2468

firestarman opened this issue May 21, 2021 · 0 comments · Fixed by #2486
Labels
feature request New feature or request

Comments

@firestarman
Copy link
Collaborator

firestarman commented May 21, 2021 •
edited
Loading

According to the comment here ,

// TODO: This null replacement is no longer necessary when
// https://github.com/rapidsai/cudf/issues/3856 is fixed.

Suppose now it is safe to remove the null replacement in GpuConditionalExpression since the issue rapidsai/cudf#3856 has been fixed by rapidsai/cudf#3911.
@firestarman firestarman added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 21, 2021
@firestarman firestarman mentioned this issue May 24, 2021
Merged
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the null replacement in computePredicate firestarman/spark-rapids
2 participants
@sameerz @firestarman