Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Adding null boolean handling for copy_if_else #3911

Merged
merged 10 commits into from
Jan 29, 2020
Merged

[REVIEW] Adding null boolean handling for copy_if_else #3911

merged 10 commits into from
Jan 29, 2020

Conversation

rgsl888prabhu
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu commented Jan 24, 2020 •
edited
Loading

Adding null boolean handling for copy_if_else.
close #3856

@rgsl888prabhu rgsl888prabhu added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond libcudf++ labels Jan 24, 2020
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner January 24, 2020 20:38
@rgsl888prabhu rgsl888prabhu self-assigned this Jan 24, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020 •
edited
Loading

Codecov Report

Merging #3911 into branch-0.13 will decrease coverage by 0.03%.
The diff coverage is 56.25%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13    #3911      +/-   ##
===============================================
- Coverage        86.78%   86.74%   -0.04%     
===============================================
  Files               50       50              
  Lines             9708     9713       +5     
===============================================
+ Hits              8425     8426       +1     
- Misses            1283     1287       +4
Impacted Files Coverage Δ
python/cudf/cudf/core/series.py 92.23% <ø> (+0.07%) ⬆️
python/cudf/cudf/core/column/column.py 85.34% <50%> (-0.11%) ⬇️
python/cudf/cudf/core/buffer.py 84.74% <57.14%> (-6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b0bb70...c88ae47. Read the comment docs.

nvdbaranec
nvdbaranec approved these changes Jan 27, 2020
View reviewed changes
cpp/src/copying/copy.cu Show resolved Hide resolved
@rgsl888prabhu rgsl888prabhu changed the title [REVIEW] Adding null boolean handling for copy_if_else [REVIEW][skip-ci] Adding null boolean handling for copy_if_else Jan 27, 2020
@rgsl888prabhu rgsl888prabhu changed the title [REVIEW][skip-ci] Adding null boolean handling for copy_if_else [REVIEW] Adding null boolean handling for copy_if_else Jan 28, 2020
@rgsl888prabhu
Copy link
Contributor Author

@davidwendt @ChuckHastings

davidwendt
davidwendt approved these changes Jan 28, 2020
View reviewed changes
cpp/src/copying/copy.cu Outdated Show resolved Hide resolved
ChuckHastings
ChuckHastings approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rgsl888prabhu
Copy link
Contributor Author

rerun tests

jrhemstad
jrhemstad requested changes Jan 28, 2020
View reviewed changes
cpp/include/cudf/copying.hpp Outdated Show resolved Hide resolved
@rgsl888prabhu
Copy link
Contributor Author

rerun tests

@rgsl888prabhu rgsl888prabhu merged commit be4435f into rapidsai:branch-0.13 Jan 29, 2020
This was referenced May 21, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@davidwendt davidwendt davidwendt approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

Assignees

@rgsl888prabhu rgsl888prabhu

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] null boolean handling for copy_if_else
5 participants
@rgsl888prabhu @jrhemstad @ChuckHastings @davidwendt @nvdbaranec