Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Spark 3.2.0 TimeAdd/TimeSub fail due to new DayTimeIntervalType #3502

Closed
tgravescs opened this issue Sep 15, 2021 · 2 comments · Fixed by #3507
Closed

[BUG] Spark 3.2.0 TimeAdd/TimeSub fail due to new DayTimeIntervalType #3502

tgravescs opened this issue Sep 15, 2021 · 2 comments · Fixed by #3507
Assignees
@wbo4958
Labels
bug Something isn't working P0 Must have for release

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
Looking at integration test failures for spark 3.2 in #3483, the TimeAdd and TimeSub tests are failing because Spark now uses DayTimeIntervalType for some sql statements and our TimeAdd/Sub don't handle them properly.

it looks pretty straight forward to add if we want to support it for those.
@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify P0 Must have for release labels Sep 15, 2021
@tgravescs tgravescs mentioned this issue Sep 15, 2021
Closed
@tgravescs tgravescs changed the title [BUG] TimeAdd/TimeSub fail due to new DayTimeIntervalType [BUG] Spark 3.2.0 TimeAdd/TimeSub fail due to new DayTimeIntervalType Sep 15, 2021
@tgravescs
Copy link
Collaborator Author

@wbo4958 were you working on this already? I know you were doing some work with DayTimeIntervalType

@wbo4958 wbo4958 self-assigned this Sep 15, 2021
@wbo4958
Copy link
Collaborator

wbo4958 commented Sep 15, 2021

@tgravescs, Yeah, I will take this one

@wbo4958 wbo4958 mentioned this issue Sep 16, 2021
Merged
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbo4958 wbo4958

Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TimeAdd supports DayTimeIntervalType wbo4958/spark-rapids
3 participants
@wbo4958 @tgravescs @Salonijain27